Add test utility to create Nexus endpoint#1279
Open
Quinn-With-Two-Ns wants to merge 2 commits intotemporalio:mainfrom
Open
Add test utility to create Nexus endpoint#1279Quinn-With-Two-Ns wants to merge 2 commits intotemporalio:mainfrom
Quinn-With-Two-Ns wants to merge 2 commits intotemporalio:mainfrom
Conversation
THardy98
approved these changes
Feb 3, 2026
Contributor
|
It does have typechecking issues however. |
9ba31d0 to
9d85501
Compare
Author
|
@THardy98 @tconley1428 Could one of you merge this PR, I now longer have permission :( |
9d85501 to
ac9dfb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test utility to create Nexus endpoint. This matches what we have in Java and Dotnet
Note
Low Risk
Test/support API addition plus straightforward test refactors; low risk aside from potential operator-service compatibility issues in environments that run these tests.
Overview
Adds first-class Nexus endpoint lifecycle helpers to
WorkflowEnvironmentvia newcreate_nexus_endpoint(name, task_queue)anddelete_nexus_endpoint(endpoint)methods backed byoperator_servicerequests.Updates Nexus-related tests to use
env.create_nexus_endpoint(...)instead of a customtests.helpers.nexus.create_nexus_endpoint, and removes that helper (leaving onlymake_nexus_endpoint_nameand other utilities).Written by Cursor Bugbot for commit ac9dfb3. This will update automatically on new commits. Configure here.